[18][account_invoice_select_for_payment] Remove the to pay mark on an invoice when it is fully paid or in payment #1453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n payment This way the module is usefull when the register payment wizard is not used. It is a case when you use payment orders or even if you reconcile your invoices from the bank statement for instance Also add a button on form view to be able to mark the invoice as to pay when you are checking what it is exactly
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
|
@aleuffre @renda-dev @Kimkhoi3010 @sebalix @TDu @grindtildeath I think it is an important improvement, a review would be appreciated. |
github-actions
bot
removed
the
stale
|
Trying once more :) |
aleuffre
approved these changes
Oct 24, 2025
| style="background-color:grey" | ||
| /> | ||
| </button> | ||
| <xpath expr="//sheet/widget[5]" position="after"> |
There was a problem hiding this comment.
question: would it be possible to choose a field in a more deterministic way?
e.g. //sheet/widget[@name='some_widget]or even//sheet/widget[last()]` ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presently, the module only works with the register payment button, which seems quite problematic, as it is normally not very used when the full accounting is done in Odoo.
Indeed, if you pay your invoice by wire transfer, the payment will come from your bank statement or from an account.payment.order for instance.
So the main change here is that the selected_for_payment is computed so it is removed when invoice is paid or in payment.
This PR includes other small improvement like :
Last thing, I think it is very weird to remove the selected_for_payment mark if one user click on the register payment button but does not proceed to the payment (cancel it).
I would remove the override of action_register_payment and only rely on the computed field to remove it...
Still I did not do it in this PR because I am not sure it is ok for everybody, and I do not really have a solution for the partial payment case.
An equivalent PR actually was already proposed/approved in v14, but was never merged see : #1317
FYI @aleuffre @renda-dev
@Kimkhoi3010 Can you re-do your review over here?
@sebalix @TDu @grindtildeath as reviewer of the migration PR it may be of your interest